Update Baselines with AWS, Azure and GCP Mod Installs #833
Conversation
baselines/aws/aws_mods/variables.tf
Outdated
| DESC | ||
| type = list(string) | ||
| type = list(string) | ||
| description = "The list of AWS Mods to install." | ||
| default = [ |
There was a problem hiding this comment.
I don't think we should have a default value for this? or if we do it should be a shorter list. we already have default.tfvars, so leaning toward not having a default in this file. or having the default just be aws by itself?
There was a problem hiding this comment.
the default.tfvars has the shorter list required to get started with CIS atleast.. The intention of having the default in here is to show case the complete list of possibilities..
If we do not want it here, then I can update the README accordingly and redirect to Guardrails Hub for complete list of Mods/services supported?
There was a problem hiding this comment.
I like the idea of using only default.tfvars with complete list and commenting out the ones not on by default.. but we will have to update the baselines as in when a new mod/policy is added/updated, whereas Guardrails Hub does that automatically. For an end-user just commenting/uncommenting the default.tfvars would be much easier rather than going back and forth between Guardrails Hub and guardrails-samples!
No description provided.